Merged
Conversation
Contributor
Author
|
Colcon has been released and colcon package list updated in this PR. This is ready for review. |
dirk-thomas
approved these changes
Jun 7, 2018
dirk-thomas
left a comment
There was a problem hiding this comment.
Without knowing much about this repo the change looks reasonable to me.
ruffsl
approved these changes
Jun 8, 2018
Member
ruffsl
left a comment
There was a problem hiding this comment.
There's a lot of colcon packages nowadays. LGTM
Contributor
Author
Yeah, actually now that all packages gracefully fall back if e.g. there is no display available, we can go back to installing the colcon "metapackage" that pulls in the various extensions we use for building. I modified the PR to that effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the templates to use colcon for the ros2 source builds.
related to ros2/ros2#493
Keeping this as WIP until the matching
docker_imagesPR is ready for review