[ROS2] Bouncy source dockerfile using new templates, colcon and updated dependency list#160
Merged
mikaelarguedas merged 15 commits intomasterfrom Jun 9, 2018
Merged
[ROS2] Bouncy source dockerfile using new templates, colcon and updated dependency list#160mikaelarguedas merged 15 commits intomasterfrom
mikaelarguedas merged 15 commits intomasterfrom
Conversation
dirk-thomas
reviewed
Jun 5, 2018
ros2/source/images.yaml.em
Outdated
| -DSECURITY=ON -- | ||
| - --isolated | ||
| - --parallel | ||
| " -DBUILD_TESTING=ON" " -DSECURITY=ON" " --no-warn-unused-cli" |
Contributor
There was a problem hiding this comment.
The leading spaces and quotes can be removed now.
Same below.
a1e8853 to
7579cd0
Compare
Contributor
Author
|
Placing this in review. |
dirk-thomas
approved these changes
Jun 7, 2018
ros2/source/images.yaml.em
Outdated
| -DSECURITY=ON -- | ||
| - --isolated | ||
| - --parallel | ||
| -DBUILD_TESTING=ON -DSECURITY=ON --no-warn-unused-cli |
Contributor
There was a problem hiding this comment.
BUILD_TESTING should be ON by default.
Same below.
31 tasks
ruffsl
approved these changes
Jun 8, 2018
4905333 to
c4e308c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #128
This changes the behavior to build
masterinstead ofrelease-latestwe~should likely go back torelease-latest` before merging.~~ will come back and go back to use release latest once bouncy is tagged and releasedUpdate the ros2 source Dockerfile to build bouncy on bionic.
This now uses colcon for the build tool and depends on osrf/docker_templates#39