Fixes network metrics #8567
Fixes network metrics #8567
Conversation
directionless
left a comment
There was a problem hiding this comment.
This came in as part of #8409 from @carlsmedstad maybe part of some arch work.
zwass
left a comment
There was a problem hiding this comment.
Works for me on macOS. Thank you! Should be ready to merge when CI passes.
directionless
left a comment
There was a problem hiding this comment.
Works for me on macOS. Thank you! Should be ready to merge when CI passes.
Hold up... As mentioned, those changes came in as part of the boost compatibility work. I don't know enough to know if that's an issue here
|
@directionless @carlsmedstad any particular concerns? The current code (post #8409) is generating 0 values while this new code is working as expected. |
|
@zwass Nope, none that I know of, this patch builds fine against Boost 1.87 on Arch Linux. |
zwass
left a comment
There was a problem hiding this comment.
@directionless I believe we are good to go here. In the interest of expediency I'm going to go ahead and merge. If you have further concerns let's please discuss and we can make any necessary modifications.
Confirmed we don't anticipate issues with the last PR that changed this.
I noticed the network metrics from the docker_container_stats table are missing, it started with the 5.14 osquery version. I saw the logic was changed in how to get the cumulative values for the network rx/tx, I changed back to the original solution.