Boost 1.86 compatibility #8409
Merged
Boost 1.86 compatibility #8409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e3d7fa to
a4aae77
Compare
boost::filesystem::path.leaf() has been removed in Boost v1.86.0.
af81879 to
9a80513
Compare
directionless
previously approved these changes
Sep 2, 2024
Fixes compatibility with Boost v1.86.0.
JSON is serialized without a trailing newline in Boost 1.86 - ensure tests pass for both old and new Boost.
9a80513 to
788415c
Compare
boost::filesystem::ofstream with std::ofstream was deprecated in 1.79 and removed somewhere between 1.83 and 1.86.
788415c to
b46f71d
Compare
directionless
approved these changes
Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again,
This PR contains changes required for compatibility with Boost 1.86.0.
For context, the complete WIP patchset for the Arch Linux package for osquery is maintained in this branch: https://github.com/carlsmedstad/osquery/tree/build-on-archlinux