Skip to content

Pin macos python versions in CI to fix mismatch between builder and test runner #8559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwass merged 1 commit into from
Mar 25, 2025
Merged

Pin macos python versions in CI to fix mismatch between builder and test runner #8559

zwass merged 1 commit into from
Mar 25, 2025

Conversation

@scottvanta
Copy link
Contributor

@scottvanta scottvanta commented Mar 3, 2025 •
edited
Loading

Changes:

  • Pin a specific Python version (3.13.1) when installing python on the macos builder and the test_older_macos runner

Motivation:

  • Fix the test_older_macos CI tests
    • Failures are of the form "Could not start process at /Users/runner/hostedtoolcache/Python/3.13.1/x64/bin/python3" (e.g. this run)
    • The macos-13 runner image was recently updated to have Python 3.13.2 but the other macos runners are still on Python 3.13.1
    • Notably, the "Setup python" step in the test_older_macos run shows "Successfully set up CPython (3.13.2)", which mismatches the version (3.13.1) that gets set up in the "Setup python" step of the build_macos (macos-14, x86_64) build that builds the macos_tests_Debug/Release artifacts uses in test_older_macos

Test plan:

  • CI
  • (I've validated that this change fixes the test_older_macos failures on a local fork with similar CI setup)

@scottvanta scottvanta requested a review from a team as a code owner March 3, 2025 19:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 3, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@zwass
Copy link
Member

zwass commented Mar 11, 2025

@scottvanta I kicked off the CI. Will be happy to merge once CI completes and you sign the CLA. Thank you!

@scottvanta
Copy link
Contributor Author

scottvanta commented Mar 11, 2025

Thanks! I've been working through the steps of getting the corporate CLA set up, hopefully should have an update soon!

@scottvanta
Copy link
Contributor Author

scottvanta commented Mar 11, 2025

Alright, CLA is signed and ready to go!

@scottvanta
Copy link
Contributor Author

scottvanta commented Mar 13, 2025

I think this is no longer strictly needed, since github updated the macos-14 image to include Python 3.13.2 as well now, so the macos-14 and macos-13 builds have a matching python version again and builds are passing, though it still seems worthwhile to pin this anyway to avoid the possibility of issues like this in the future.

zwass
zwass approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Scott for the PR and further commentary! I think it makes sense to pin it like you said.

@zwass zwass merged commit 2801baf into osquery:master Mar 25, 2025
22 checks passed
ksykulev pushed a commit to ksykulev/osquery that referenced this pull request Mar 29, 2025
@scottvanta @ksykulev
Pin macos python versions in CI to fix mismatch between builder and t…
94ff80d 
…est runner (osquery#8559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwass zwass zwass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scottvanta @zwass