Correct spec file name to macwin
#8311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c5cb3f to
87bd7c0
Compare
directionless
added a commit
to directionless/osquery-site
that referenced
this pull request
Apr 18, 2024
This is a manually one, not in GHA, to work around osquery/osquery#8311
zwass
reviewed
Apr 23, 2024
Member
zwass
left a comment
There was a problem hiding this comment.
Does the battery.table file need to be moved to a different directory as well?
directionless
added a commit
to osquery/osquery-site
that referenced
this pull request
Apr 23, 2024
This is a manually one, not in GHA, to work around osquery/osquery#8311
Member
Author
It did get moved. The GH ui might not be as clear any more |
Smjert
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8267 we added windows support to the battery table. But, in doing so, it was moved to
darwindows. Unfortunately, the rest of our tooling expectedmacwin.I have renamed the spec file, and added the
genwebsitejson.pyto CI