perf(internal/bits): Significantly speedup bitArray.PickRandom (backp…#28
Merged
czarcas7ic merged 4 commits intoosmo/v0.37.4from Apr 30, 2024
Merged
Conversation
…ort cometbft#2841) (cometbft#2887) This PR significantly speeds up bitArray.PickRandom which is used in VoteGossip and BlockPart gossip. We saw for a query serving full node, over an hour, this was a very large amount of RAM allocations. (75GB of RAM!)  This PR drops it down to 0 allocations, and makes the routine 10x faster on my machine. OLD: ``` BenchmarkPickRandomBitArray-12 1545199 846.1 ns/op 1280 B/op 1 allocs/op ``` NEW: ``` BenchmarkPickRandomBitArray-12 22192857 75.39 ns/op 0 B/op 0 allocs/op ``` I think the new tests I wrote make this more tested than the old code that was here tbh, but pls let me know if theres more tests we'd like to see! --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2841 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Member
Author
|
@ValarDragon had to make the following change to get this to pass CI, just highlighting 499cfee |
ValarDragon
approved these changes
Apr 29, 2024
mergify bot
added a commit
that referenced
this pull request
Apr 30, 2024
#28) * perf(internal/bits): Significantly speedup bitArray.PickRandom (backport cometbft#2841) (cometbft#2887) This PR significantly speeds up bitArray.PickRandom which is used in VoteGossip and BlockPart gossip. We saw for a query serving full node, over an hour, this was a very large amount of RAM allocations. (75GB of RAM!)  This PR drops it down to 0 allocations, and makes the routine 10x faster on my machine. OLD: ``` BenchmarkPickRandomBitArray-12 1545199 846.1 ns/op 1280 B/op 1 allocs/op ``` NEW: ``` BenchmarkPickRandomBitArray-12 22192857 75.39 ns/op 0 B/op 0 allocs/op ``` I think the new tests I wrote make this more tested than the old code that was here tbh, but pls let me know if theres more tests we'd like to see! --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2841 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> * fix failing test * changelog --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit f6abfce)
7 tasks
czarcas7ic
added a commit
that referenced
this pull request
Apr 30, 2024
#28) (#32) * perf(internal/bits): Significantly speedup bitArray.PickRandom (backport cometbft#2841) (cometbft#2887) This PR significantly speeds up bitArray.PickRandom which is used in VoteGossip and BlockPart gossip. We saw for a query serving full node, over an hour, this was a very large amount of RAM allocations. (75GB of RAM!)  This PR drops it down to 0 allocations, and makes the routine 10x faster on my machine. OLD: ``` BenchmarkPickRandomBitArray-12 1545199 846.1 ns/op 1280 B/op 1 allocs/op ``` NEW: ``` BenchmarkPickRandomBitArray-12 22192857 75.39 ns/op 0 B/op 0 allocs/op ``` I think the new tests I wrote make this more tested than the old code that was here tbh, but pls let me know if theres more tests we'd like to see! --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request cometbft#2841 done by [Mergify](https://mergify.com). --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> * fix failing test * changelog --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit f6abfce) Co-authored-by: Adam Tucker <adam@osmosis.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ort cometbft#2841) (cometbft#2887)
This PR significantly speeds up bitArray.PickRandom which is used in VoteGossip and BlockPart gossip. We saw for a query serving full node, over an hour, this was a very large amount of RAM allocations. (75GB of RAM!)
This PR drops it down to 0 allocations, and makes the routine 10x faster on my machine.
OLD:
NEW:
I think the new tests I wrote make this more tested than the old code that was here tbh, but pls let me know if theres more tests we'd like to see!
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request perf(internal/bits): Significantly speedup bitArray.PickRandom cometbft/cometbft#2841 done by Mergify.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments