Use jl_reinit_foreign_type if available#845
Merged
fingolfin merged 1 commit intooscar-system:masterfrom Nov 28, 2022
Merged
Conversation
b89f6a4 to
d18469d
Compare
jl_reinit_foreign_type
5f2b034 to
6df5a20
Compare
jl_reinit_foreign_type6df5a20 to
f2ea074
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #845 +/- ##
==========================================
- Coverage 81.56% 81.41% -0.16%
==========================================
Files 48 48
Lines 3656 3664 +8
==========================================
+ Hits 2982 2983 +1
- Misses 674 681 +7
|
jl_reinit_foreign_type when available
f2ea074 to
9b4bf31
Compare
jl_reinit_foreign_type when availablejl_reinit_foreign_type if available
This prepares us for an upcoming change to serialization in Julia 1.10.
9b4bf31 to
b75b036
Compare
8 tasks
ThomasBreuer
approved these changes
Nov 28, 2022
Member
ThomasBreuer
left a comment
There was a problem hiding this comment.
As far as I see, these changes will work as soon as the changes from gap-system/gap/pull/5224 are available.
Member
Author
|
Note that the code in this PR is written in such a way that it should also work now, before those changes on the GAP and Julia side -- this is required so we stay compatible with Julia <= 1.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares us for an upcoming change to serialization in Julia 1.10, see issue #846.