Use jl_reinit_foreign_type if available#5224
Merged
fingolfin merged 3 commits intogap-system:masterfrom Nov 28, 2022
Merged
Conversation
This was referenced Nov 25, 2022
9b3e48f to
6919b0a
Compare
jl_reinit_foreign_type if available
1b72a2a to
6c7b208
Compare
6c7b208 to
6bf3057
Compare
8 tasks
ThomasBreuer
approved these changes
Nov 28, 2022
Contributor
ThomasBreuer
left a comment
There was a problem hiding this comment.
As far as I see, this looks good. (@ChrisJefferson will be able to give detailed comments.)
Member
Author
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the plan outlined in oscar-system/GAP.jl#846