stages/bootc.install-to-filesystem: add more knobs#2152
Merged
supakeen merged 2 commits intoosbuild:mainfrom Aug 15, 2025
Merged
stages/bootc.install-to-filesystem: add more knobs#2152supakeen merged 2 commits intoosbuild:mainfrom
supakeen merged 2 commits intoosbuild:mainfrom
Conversation
2128b2a to
f48a3fc
Compare
Contributor
Author
|
Pushed an extra commit with more knobs |
5fac552 to
14d2134
Compare
mvo5
reviewed
Jul 22, 2025
Contributor
mvo5
left a comment
There was a problem hiding this comment.
Thanks for this change, the change itself looks (mostly) fine but see my comment inline. It would also be super nice to have a test added to stages/test/test_bootc_install_to_fs.py at least to the # all test there) but we can also do that for yo if you are busy.
14d2134 to
6367e8f
Compare
6367e8f to
0de5cc7
Compare
supakeen
approved these changes
Jul 28, 2025
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Jul 30, 2025
Theses are patch from the following PRs: osbuild/osbuild#2152 osbuild/osbuild#2149
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Jul 30, 2025
Theses are patch from the following PRs: osbuild/osbuild#2152 osbuild/osbuild#2149
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Jul 30, 2025
Theses are patch from the following PRs: osbuild/osbuild#2152 osbuild/osbuild#2149
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Jul 30, 2025
Theses are patch from the following PRs: osbuild/osbuild#2152 osbuild/osbuild#2149
thozza
approved these changes
Aug 4, 2025
Member
thozza
left a comment
There was a problem hiding this comment.
I've added a few nitpicks, but I would not block on them.
This adds an extra option to make the stateroot name customizable. Fixes osbuild#2151
Allow passing custom mount specs for boot and root. Optional fields.
Contributor
Author
|
Thanks for merging that ! Sorry for not adressing some of the comments, I was on PTO. |
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Aug 28, 2025
Theses are patch from the following PRs: osbuild/osbuild#2152 osbuild/osbuild#2149
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Aug 28, 2025
Theses are patch from the following PRs: osbuild/osbuild#2152 osbuild/osbuild#2149
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Aug 28, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Sep 8, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Sep 8, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Oct 27, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Oct 28, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Oct 28, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Oct 29, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Dec 2, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Dec 3, 2025
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Jan 14, 2026
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Feb 16, 2026
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. Right now this requires to use the image as the buildroot so this requires python (for osbuild). This is tracked in [1]. As we have python in rawhide now I duplicated the manifest and added a switch in the osbuild wrapper script. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Mar 2, 2026
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Mar 2, 2026
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. We can keep the manifest duplicated until we are confident to roll this to all streams. [1] bootc-dev/bootc#1410 Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 bootc-dev/bootc#1978 bootc-dev/bootc#1909 All of which have landed in osbuild-159 and bootc 1.6
jbtrystram
added a commit
to jbtrystram/coreos-assembler
that referenced
this pull request
Mar 2, 2026
Instead of deploying the container to the tree then copy all the contents to the disk image, use bootc to directly manage the installation to the target filesystems. We can keep the manifest duplicated until we are confident to roll this to all streams or move to image-builder. Requires: bootc-dev/bootc#1460 bootc-dev/bootc#1451 osbuild/osbuild#2149 osbuild/osbuild#2152 bootc-dev/bootc#1978 bootc-dev/bootc#1909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an extra option to make the stateroot name customizable.
Fixes #2151