Remove ISOLabelTmpl from all installer image kinds#542
Merged
achilleas-k merged 2 commits intoosbuild:mainfrom Mar 25, 2024
Merged
Remove ISOLabelTmpl from all installer image kinds#542achilleas-k merged 2 commits intoosbuild:mainfrom
achilleas-k merged 2 commits intoosbuild:mainfrom
Conversation
Add two new methods to the `distro.Distro` interface, specifically `OsVersion()` and `Product()`, which are common properties of all distro implementations. Add a new `ISOLabel()` method to the `distro.ImageType` interface, which will be used by installer image types to get distro-specific ISO label. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Do not define ISO label templates on distro / image type levels, which are then passed to the installer image kind. Instead, allow each image type to define its own function to generate the final ISO Label to be used for the image type. Pass the final ISO label to the installer image kinds to be used as is. Fix osbuild#491 Signed-off-by: Tomáš Hozza <thozza@redhat.com>
achilleas-k
approved these changes
Mar 25, 2024
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Mar 26, 2024
This was removed in osbuild/images#542
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Apr 2, 2024
This was removed in osbuild/images#542
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not define ISO label templates on distro / image type levels, which
are then passed to the installer image kind. Instead, allow each image
type to define its own function to generate the final ISO Label to be
used for the image type. Pass the final ISO label to the installer image
kinds to be used as is.
Fix #491