bootc: allow ignition first boot stage in blueprint by jbtrystram · Pull Request #2222 · osbuild/images

jbtrystram · 2026-02-23T15:15:47Z

This allow setting a Firstboot.Ignition.Enable boolean to inject the igntition firstboot stage[1] after the container is deployed.

Requires osbuild/blueprint#46 [1] https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.ignition

supakeen · 2026-02-26T06:02:07Z

I've done a release of the blueprint library so you can update the dependency here and the option will be available in the code.

supakeen

Getting there; the errors returned now need to be handled and I see c.GetISO() now also returns an error. That was my mistake as I implemented that but never updated blueprint in images.

I can make a PR or you can fix it in this PR; what do you prefer?

In [1] customizations.GetISO was updated to return an error, handle that [1] osbuild/blueprint@a072bbf

jbtrystram · 2026-02-26T10:48:16Z

Getting there; the errors returned now need to be handled and I see c.GetISO() now also returns an error. That was my mistake as I implemented that but never updated blueprint in images.

I'll add a commit here :)

pkg/distro/generic/bootc_imagetype.go

pkg/distro/generic/options.go

jbtrystram · 2026-02-26T15:26:05Z

@supakeen I added a second commit here to handle osbuild/osbuild#2149 but it feel quite crudes and does not work. The generated manifest looks correct though, so I am not sure what is happening.

This requires a local build of osbuild/images#2222 Then to test: ``` IBC_IMAGE=localhost/ibc sudo podman build -t localhost/ibc -f Containerfile-ibc alias ibc='sudo podman run --rm --privileged --network=none -v /var/lib/containers/storage:/var/lib/containers/storage -v ./output:/output -v ./fcos-bp.toml:/fcos-bp.toml $IBC_IMAGE' ibc build qcow2 \ --bootc-build-ref $BUILDER_IMAGE \ --bootc-ref $TARGET_FCOS_IMAGE \ --output-dir fedora-coreos \ --output-name fedora-coreos-rawhide \ --with-buildlog \ --with-manifest \ --with-metrics --blueprint /fcos-bp.toml ```

pkg/manifest/raw_bootc.go

supakeen

Thanks this looks OK to me.

The commits could be redone a bit (e.g. first introduce the blueprint bump + the changes that needs) then a commit to use the new customizations but I won't block on that as it's pretty minor.

supakeen · 2026-02-27T09:17:44Z

pkg/manifest/raw_bootc.go

+		}
+		var err error
+		// We cannot reuse the existing mounts because the generated ostree mounts are shadowing /boot and the file ends up
+		// in the wrong place. We reuse the bootupd mount generator as it's enough for this. We just need /boot.


❤️ for adding this in a comment as well.

This allow setting a `Firstboot.Ignition.Empty` boolean to inject the igntition firstboot stage[1] after the container is deployed. Note that we specify the target directory to create the `ignition.firstboot` stamp, as introduced in [2]. This is required because `bootc install to-filesystem` wants an empty /boot FS, so we need to run the stage after. We reuse the bootupd mounts generator. We really only need /boot, so bootupd is probably a bit overkill but does the job. We cannot reuse the existing mounts here because the `ostree` generated mounts are shadowing /boot so the file end up in the wrong place. Requires osbuild/blueprint#46 [1] https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.ignition [2] osbuild/osbuild#2149 Signed-off-by: jbtrystram <jbtrystram@redhat.com> Co-authored-by: Simon de Vlieger <cmdr@supakeen.com>

jbtrystram · 2026-02-27T14:09:23Z

The commits could be redone a bit (e.g. first introduce the blueprint bump + the changes that needs) then a commit to use the new customizations but I won't block on that as it's pretty minor.

I cleaned up the commits :) It was a nice opportunity to practice some git-fu !

supakeen · 2026-02-27T14:14:50Z

The commits could be redone a bit (e.g. first introduce the blueprint bump + the changes that needs) then a commit to use the new customizations but I won't block on that as it's pretty minor.

I cleaned up the commits :) It was a nice opportunity to practice some git-fu !

And you did it so that the diffs didn't change so the approval I gave didn't get dismissed.

If you want, I think you can order the 'update to blueprints 1.25.0' before the ' allow ignition first boot stage' thing.

See https://issues.redhat.com/browse/HMS-10227 This requires a local build of osbuild/images#2222 Then to test: ``` IBC_IMAGE=localhost/ibc sudo podman build -t localhost/ibc -f Containerfile-ibc alias ibc='sudo podman run --rm --privileged --network=none -v /var/lib/containers/storage:/var/lib/containers/storage -v ./output:/output -v ./fcos-bp.toml:/fcos-bp.toml $IBC_IMAGE' ibc build qcow2 \ --bootc-build-ref $BUILDER_IMAGE \ --bootc-ref $TARGET_FCOS_IMAGE \ --output-dir fedora-coreos \ --output-name fedora-coreos-rawhide \ --with-buildlog \ --with-manifest \ --with-metrics --blueprint /fcos-bp.toml ``` Alternatively, use quay.io/jbtrystramtestimages/cosa-ib

jbtrystram · 2026-02-27T14:20:10Z

If you want, I think you can order the 'update to blueprints 1.25.0' before the ' allow ignition first boot stage' thing.

It's already in that order

See https://issues.redhat.com/browse/HMS-10227 This requires a local build of osbuild/images#2222 Then to test: ``` IBC_IMAGE=localhost/ibc sudo podman build -t localhost/ibc -f Containerfile-ibc alias ibc='sudo podman run --rm --privileged --network=none -v /var/lib/containers/storage:/var/lib/containers/storage -v ./output:/output -v ./fcos-bp.toml:/fcos-bp.toml $IBC_IMAGE' ibc build qcow2 \ --bootc-build-ref $BUILDER_IMAGE \ --bootc-ref $TARGET_FCOS_IMAGE \ --output-dir fedora-coreos \ --output-name fedora-coreos-rawhide \ --with-buildlog \ --with-manifest \ --with-metrics --blueprint /fcos-bp.toml ``` Alternatively, use quay.io/jbtrystramtestimages/cosa-ib

supakeen · 2026-02-27T14:23:44Z

If you want, I think you can order the 'update to blueprints 1.25.0' before the ' allow ignition first boot stage' thing.

It's already in that order

Ah, GitHub UI being silly. Disregard :)

This image contains osbuild/images#2222

achilleas-k

This isn't tested anywhere but I trust you tried it already with your own builds. We should add some FCOS manifests to test these things at some point.

jbtrystram · 2026-02-27T15:25:17Z

This isn't tested anywhere but I trust you tried it already with your own builds. We should add some FCOS manifests to test these things at some point.

I'll file something to track this as part of our overall effort of moving to image-builder

This comment was marked as resolved.

Sign in to view

supakeen self-assigned this Feb 23, 2026

supakeen self-requested a review February 23, 2026 15:27

supakeen mentioned this pull request Feb 24, 2026

Customization: Add a empty boolean to ignition osbuild/blueprint#46

Merged

jbtrystram force-pushed the add_ignition_to_bootc branch 2 times, most recently from f0ed2b5 to 21bc18c Compare February 26, 2026 09:27

supakeen force-pushed the add_ignition_to_bootc branch from 21bc18c to 0a1ae10 Compare February 26, 2026 09:45

supakeen reviewed Feb 26, 2026

View reviewed changes

generic/images: handle getISO error

2ca7a30

In [1] customizations.GetISO was updated to return an error, handle that [1] osbuild/blueprint@a072bbf

jbtrystram force-pushed the add_ignition_to_bootc branch 2 times, most recently from 57c5090 to 5641cd7 Compare February 26, 2026 11:02

supakeen reviewed Feb 26, 2026

View reviewed changes

pkg/distro/generic/bootc_imagetype.go Show resolved Hide resolved

jbtrystram force-pushed the add_ignition_to_bootc branch 2 times, most recently from 17f3c71 to 7e48e57 Compare February 26, 2026 11:40

jbtrystram marked this pull request as ready for review February 26, 2026 12:00

jbtrystram requested a review from a team as a code owner February 26, 2026 12:00

jbtrystram requested review from bcl, lzap and supakeen February 26, 2026 12:00

jbtrystram marked this pull request as draft February 26, 2026 12:00

supakeen reviewed Feb 26, 2026

View reviewed changes

pkg/distro/generic/options.go Outdated Show resolved Hide resolved

jbtrystram force-pushed the add_ignition_to_bootc branch 2 times, most recently from d60302c to b0248f0 Compare February 26, 2026 15:24

jbtrystram mentioned this pull request Feb 26, 2026

use a blueprint for ignition.firstboot joelcapitao/bib-fcos-experimentation#6

Merged

supakeen reviewed Feb 26, 2026

View reviewed changes

pkg/manifest/raw_bootc.go Outdated Show resolved Hide resolved

jbtrystram marked this pull request as ready for review February 27, 2026 08:10

jbtrystram force-pushed the add_ignition_to_bootc branch from b0248f0 to a66cb0c Compare February 27, 2026 08:11

supakeen mentioned this pull request Feb 27, 2026

distro: apply sshd customizations (HMS-10259) #2234

Draft

supakeen requested review from achilleas-k and supakeen February 27, 2026 08:21

joelcapitao mentioned this pull request Feb 27, 2026

bootc-image-builder is missing ignition support joelcapitao/bib-fcos-experimentation#1

Closed

supakeen approved these changes Feb 27, 2026

View reviewed changes

jbtrystram and others added 2 commits February 27, 2026 14:58

deps: bump osbuild/blueprint to 1.25.0

c11b44c

jbtrystram force-pushed the add_ignition_to_bootc branch from a66cb0c to 4868e5c Compare February 27, 2026 14:08

jbtrystram enabled auto-merge February 27, 2026 14:28

joelcapitao added a commit to joelcapitao/bib-fcos-experimentation that referenced this pull request Feb 27, 2026

Add custom i-b-c image

780cd9a

This image contains osbuild/images#2222

lzap approved these changes Feb 27, 2026

View reviewed changes

jbtrystram added this pull request to the merge queue Feb 27, 2026

achilleas-k approved these changes Feb 27, 2026

View reviewed changes

Merged via the queue into osbuild:main with commit e5dcc45 Feb 27, 2026
25 checks passed

jbtrystram deleted the add_ignition_to_bootc branch February 27, 2026 16:06

Conversation

jbtrystram commented Feb 23, 2026

Uh oh!

This comment was marked as resolved.

supakeen commented Feb 26, 2026

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

jbtrystram commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

jbtrystram commented Feb 26, 2026

Uh oh!

Uh oh!

supakeen left a comment

Choose a reason for hiding this comment

Uh oh!

supakeen Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

jbtrystram commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supakeen commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbtrystram commented Feb 27, 2026

Uh oh!

supakeen commented Feb 27, 2026

Uh oh!

achilleas-k left a comment

Choose a reason for hiding this comment

Uh oh!

jbtrystram commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jbtrystram commented Feb 27, 2026 •

edited

Loading

supakeen commented Feb 27, 2026 •

edited

Loading