main: update for new reporegistry.New() api (c.f. pr#1179)#128
Merged
mvo5 merged 2 commits intoosbuild:mainfrom Feb 11, 2025
Merged
main: update for new reporegistry.New() api (c.f. pr#1179)#128mvo5 merged 2 commits intoosbuild:mainfrom
mvo5 merged 2 commits intoosbuild:mainfrom
Conversation
f23af59 to
602905d
Compare
This commit updates ibcli for the new API in images for the `reporegistry.New()`. The main incompatible change is that the `/repositories` part is not longer automatically added inside the library so we need to add it on the call-site. This needs osbuild/images#1179
602905d to
0678d8d
Compare
mvo5
added a commit
to mvo5/image-builder-cli
that referenced
this pull request
Oct 30, 2025
This commit fixes the missing appending of `repositories` when `--data-dirs` is used. It also improves the tests a bit to ensure this won't happen again. Thanks to Achilleas for finding this! This was missing when we did osbuild#128
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
This commit fixes the missing appending of `repositories` when `--data-dirs` is used. It also improves the tests a bit to ensure this won't happen again. Thanks to Achilleas for finding this! This was missing when we did #128
mvo5
added a commit
to mvo5/image-builder-cli
that referenced
this pull request
Dec 8, 2025
This commit fixes the missing appending of `repositories` when `--data-dirs` is used. It also improves the tests a bit to ensure this won't happen again. Thanks to Achilleas for finding this! This was missing when we did osbuild#128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates ibcli for the new API in images for the
reporegistry.New(). The main incompatible change is that the/repositoriespart is not longer automatically added inside the library so we need to add it on the call-site.This needs osbuild/images#1179