test: check that bootc status contains the right container_ref#360
Merged
ondrejbudai merged 1 commit intoosbuild:mainfrom Apr 17, 2024
Merged
test: check that bootc status contains the right container_ref#360ondrejbudai merged 1 commit intoosbuild:mainfrom
bootc status contains the right container_ref#360ondrejbudai merged 1 commit intoosbuild:mainfrom
Conversation
ondrejbudai
previously approved these changes
Apr 17, 2024
Member
ondrejbudai
left a comment
There was a problem hiding this comment.
Thanks for figuring out a workaround! ❤️
achilleas-k
previously approved these changes
Apr 17, 2024
5e6274c to
9fed639
Compare
9fed639 to
a9b31ff
Compare
We are currently not testing that when the build image has a valid `bootc status` that container the original container reference.
a9b31ff to
9caf998
Compare
ondrejbudai
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently not testing that when the build image has a valid
bootc statusthat container the original container reference.Alternative version to #357 that works without creating a root user which seems broken right now on fedora but that needs to get investigated later.