bib: mount devtmpfs inside the container too#238
Merged
cgwalters merged 2 commits intoosbuild:mainfrom Mar 6, 2024
Merged
Conversation
mvo5
added a commit
to mvo5/osbuild
that referenced
this pull request
Mar 6, 2024
This reverts commit 158acaa. With osbuild/bootc-image-builder#238 the original reason to call mknod goes away so we can just revert it. osbuild now requires not only the loop device but also uses `losetup --partscan` quite a lot now so the mknod approach becomes impractical and the consumers of osbuild in a container should just setup devtmpfs.
cgwalters
approved these changes
Mar 6, 2024
Contributor
|
Tempting to merge over red because we know this can't break the ISO... |
Contributor
|
Ah man, shouldn't have clicked the "merge main" button, I thought it was fast forward. I assume we don't want merge commits in this repo. |
This ensures that the new `partscan` feature in osbuild works. By default the containers only have a static snapshot of /dev on a tmpfs. This means that anything later added by losetup will be missing inside the container. It also means that osbuild/osbuild#1468 can be reverted.
4e8efba to
3673011
Compare
mvo5
added a commit
to mvo5/osbuild
that referenced
this pull request
Mar 11, 2024
This reverts commit 158acaa. With osbuild/bootc-image-builder#238 the original reason to call mknod goes away so we can just revert it. osbuild now requires not only the loop device but also uses `losetup --partscan` quite a lot now so the mknod approach becomes impractical and the consumers of osbuild in a container should just setup devtmpfs.
bcl
pushed a commit
to mvo5/osbuild
that referenced
this pull request
Mar 12, 2024
This reverts commit 158acaa. With osbuild/bootc-image-builder#238 the original reason to call mknod goes away so we can just revert it. osbuild now requires not only the loop device but also uses `losetup --partscan` quite a lot now so the mknod approach becomes impractical and the consumers of osbuild in a container should just setup devtmpfs.
bcl
pushed a commit
to mvo5/osbuild
that referenced
this pull request
Mar 13, 2024
This reverts commit 158acaa. With osbuild/bootc-image-builder#238 the original reason to call mknod goes away so we can just revert it. osbuild now requires not only the loop device but also uses `losetup --partscan` quite a lot now so the mknod approach becomes impractical and the consumers of osbuild in a container should just setup devtmpfs.
achilleas-k
pushed a commit
to osbuild/osbuild
that referenced
this pull request
Mar 13, 2024
This reverts commit 158acaa. With osbuild/bootc-image-builder#238 the original reason to call mknod goes away so we can just revert it. osbuild now requires not only the loop device but also uses `losetup --partscan` quite a lot now so the mknod approach becomes impractical and the consumers of osbuild in a container should just setup devtmpfs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the new
partscanfeature in osbuild works. By default the containers only have a static snapshot of /dev on a tmpfs. This means that anything later added by losetup will be missing inside the container.It also means that osbuild/osbuild#1468 can be reverted.
This should unblock #120 and also osbuild/images#462