Allow /quit with a message
#395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osa1
approved these changes
Dec 10, 2022
Owner
osa1
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Should we add the same parameter to /close as well, to be used in quit message when the closed tab is a server tab?
Contributor
Author
|
added the same parameters to the |
Owner
|
Thanks! |
osa1
added a commit
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an optional message parameter to the
/quitcommand to be sent to the connected servers as a reason for leaving.This pull request was tested by using a tiny and a HexChat client, both connected to the same server.
Fixes #365.