Refactor and fix IRC formatting handling #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
Contributor
|
Nice refactor and parser! |
osa1
added a commit
that referenced
this pull request
Oct 6, 2021
This PR implements IRC formatting parsing, as described in https://modern.ircdocs.horse/formatting.html Previously we were only parsing the color codes (starting with `\x03`), rest of the formatting characters were ignored. We now parse all formatting characters, but formatting characters other than two-digit color codes, "reverse" (reverses current background and foreground colors), and "reset" (resets formatting to default) are currently ignored. Handling those is left for another PR. Logger now filters out all control characters before writing to a file. I also refactored mapping IRC colors to termbox colors. Previously, for some colors, we used ANSI terminal colors in range 0-15, but those colors change depending on the terminal color scheme (not sure if this is part of the ANSI standard, or just something terminals do to implement color schemes). So we now map IRC color codes to ANSI colors in range 16-255.
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements IRC formatting parsing, as described in
https://modern.ircdocs.horse/formatting.html
Previously we were only parsing the color codes (starting with
\x03), rest ofthe formatting characters were ignored.
We now parse all formatting characters, but formatting characters other than
two-digit color codes, "reverse" (reverses current background and foreground
colors), and "reset" (resets formatting to default) are currently ignored.
Handling those is left for another PR.
Logger now filters out all control characters before writing to a file.
I also refactored mapping IRC colors to termbox colors. Previously, for some
colors, we used ANSI terminal colors in range 0-15, but those colors change
depending on the terminal color scheme (not sure if this is part of the ANSI
standard, or just something terminals do to implement color schemes). So we now
map IRC color codes to ANSI colors in range 16-255.