Fix $EDITOR support #222
Merged
Fix $EDITOR support #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b005d0 to
65e9079
Compare
Previously running $EDITOR would block tokio event loop, which causes all kinds of panics, and timeouts in connections, see #185 as an example. We now run $EDITOR in a new thread, and stop reading stdin in the input handler task during that. Also fixes termbox's suspend method, which previously keps using tty after suspend. See also module documentation of `editor`. Fixes #185
Owner
Author
|
I tried this by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously running $EDITOR would block tokio event loop, which causes
all kinds of panics, and timeouts in connections, see #185 as an
example.
We now run $EDITOR in a new thread, and stop reading stdin in the input
handler task during that. Also fixes termbox's suspend method, which
previously keps using tty after suspend.
See also module documentation of
editor.Fixes #185