feat: Admin API for deleting access token of a client#2058
Merged
aeneasr merged 5 commits intoory:masterfrom Sep 20, 2020
Merged
feat: Admin API for deleting access token of a client#2058aeneasr merged 5 commits intoory:masterfrom
aeneasr merged 5 commits intoory:masterfrom
Conversation
|
|
zepatrik
requested changes
Sep 17, 2020
Member
zepatrik
left a comment
There was a problem hiding this comment.
Thank you, this looks good 👍
I think the only thing that's missing is tests for the storage.
Contributor
Author
Added a new test for the storage |
aeneasr
reviewed
Sep 19, 2020
aeneasr
approved these changes
Sep 20, 2020
Member
aeneasr
left a comment
There was a problem hiding this comment.
Awesome 🎉
Thank you for your contribution!
zepatrik
added a commit
that referenced
this pull request
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#1728
Proposed changes
Introduced a new admin API for deleting tokens of a client. The API is in the following format
DELETE <hydra-admin>/oauth2/tokens?client_id=...Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments
I haven't generated the documentation since my local copy was changing the format of the existing contents. If that is ok I can run the doc gen task and commit the generated docs.