Geometry performance improvements #391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auto-downloading needed JDK) * Updated dependencies and version catalog made more readable * Removed unneccessary public and abstract modifiers from interface methods
…t the cost of slightly less readable code
Contributor
Author
|
Performance optimization and added tests for Matrix2d and Vector2d. About 10-15% speedup for a relatively large model in faceIndicesOnHalfedge at the cost of slightly less legible code. |
Contributor
Author
|
Besides the changes in this PR, I also tried a number of different improvements, but they didn't give any measurable improvement, at least for my test case, and some even decreased performance significantly. In no particular order:
|
Contributor
|
A little hard to see the changes from the previous PR #390 since this PR has the same commits. |
Contributor
Author
|
Closing in order to open new PR relative to the new master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.