Gradle cleanup, interface definition cleanup #390
Conversation
mkosmul
commented
Oct 16, 2024
- Using Gradle toolchain for easier compilation on various machines (auto-downloading needed JDK)
- Updated dependencies and version catalog made more readable
- Removed unneccessary public and abstract modifiers from interface methods
…auto-downloading needed JDK) * Updated dependencies and version catalog made more readable * Removed unneccessary public and abstract modifiers from interface methods
Ooouch1
left a comment
There was a problem hiding this comment.
Good updates. Leave the "public" in comments remaining, or remove all license comments from the code.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
I know putting a license comment in every code is an old way and annoying, though.
There was a problem hiding this comment.
Sorry, my oversight. I'll fix this in a moment.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
| * Copyright (C) 2005-2009 Jun Mitani http://mitani.cs.tsukuba.ac.jp/ | ||
| This program is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by |
There was a problem hiding this comment.
The "public" in comments should not be removed.
Ooouch1
left a comment
There was a problem hiding this comment.
Cool. You can merge this PR if allowed. (I'm not sure the project setting allows you to merge...)
Unfortunately, I don't have permission to merge. |