Skip to content

#65 Break loop rather than return so drops through to calcCRC#97

Merged
orgua merged 3 commits intoorgua:mainfrom
raintonr:issue/65/DS2438Loxone
Oct 8, 2022
Merged

#65 Break loop rather than return so drops through to calcCRC#97
orgua merged 3 commits intoorgua:mainfrom
raintonr:issue/65/DS2438Loxone

Conversation

@raintonr
Copy link
Contributor

@raintonr raintonr commented Dec 28, 2020

Using a Loxone master, this change makes the sensor reliably appear. Before the change, sensor could be detected with a scan but never read. Fixes #65.

@raintonr raintonr mentioned this pull request Dec 28, 2020
…evioulsy possible that this could return without resetting so moved to caller as proposed in that comment.
@raintonr raintonr mentioned this pull request Dec 28, 2020
raintonr added a commit to raintonr/arduino-sensors-for-loxone that referenced this pull request Jan 4, 2021
@orgua
Copy link
Owner

orgua commented Oct 8, 2022

looks good. thanks! and sorry for the long delay :(

@orgua orgua merged commit 4ef93aa into orgua:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loxone and Wemos D1

2 participants