(fix) org-roam-file-p handle opening a buffer with no path#2169
Merged
jethrokuan merged 2 commits intoorg-roam:mainfrom Apr 23, 2022
c1-g:fix-epub
Merged
(fix) org-roam-file-p handle opening a buffer with no path#2169jethrokuan merged 2 commits intoorg-roam:mainfrom c1-g:fix-epub
org-roam-file-p handle opening a buffer with no path#2169jethrokuan merged 2 commits intoorg-roam:mainfrom
c1-g:fix-epub
Conversation
Found this issue when opening a .epub file with nov.el (a package that renders EPUB file) because nov.el doesn't store the filename in buffer-file-name, opening it caused errors with org-roam-file-p.
Member
|
Good catch, but I think it's better to just return |
Contributor
Author
|
With the new commit, I've done exactly as you said. Now, it will just return |
Member
|
Thanks! |
|
@jethrokuan This seems to be reverted in #2171. Was it intended? I'm facing the same issue in the latest version of org-roam |
Member
|
urgh my bad |
jethrokuan
added a commit
that referenced
this pull request
May 8, 2022
jethrokuan
added a commit
that referenced
this pull request
May 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Errors when opening a .epub file with nov.el (a package
that renders EPUB file) because nov.el doesn't store the filename
in
buffer-file-name, opening it caused errors withorg-roam-file-p.The error is documented in #2163