Add column "filetitle" to table "file"; adapt queries to that change#1963
Merged
jethrokuan merged 4 commits intoorg-roam:masterfrom Nov 12, 2021
Merged
Add column "filetitle" to table "file"; adapt queries to that change#1963jethrokuan merged 4 commits intoorg-roam:masterfrom
jethrokuan merged 4 commits intoorg-roam:masterfrom
Conversation
The column "filetitle" is populated with the document title or, if there is none, the basic filename (sans extension) of the file. It is copied into the org-roam-node when retrieving nodes.
jethrokuan
reviewed
Nov 12, 2021
Member
jethrokuan
left a comment
There was a problem hiding this comment.
Just some small nits, but looks good to me otherwise.
Contributor
Author
|
Sorry I am at a loss why "some checks where not successful." CI seems to complain about wrong indentation? If I run |
1 task
This was referenced May 8, 2022
hlissner
added a commit
to doomemacs/doomemacs
that referenced
this pull request
May 9, 2022
org-roam-get-keyword performs some file IO to read file keywords from all nodes. This can be slow with long node lists. With org-roam/org-roam#1963, file title is baked into the schema, so we don't need to do this work anymore. Ref: org-roam/org-roam#1963 Fix: #6382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The column "filetitle" is populated with the document title or, if
there is none, the basic filename (sans extension) of the file. It is
copied into the org-roam-node when retrieving nodes.
Motivation for this change
See #1956