Refactor test names, get rid of runblocking#221
Merged
Conversation
mattmook
reviewed
May 22, 2024
website/docs/Test/new.md
Outdated
| --- | ||
|
|
||
| # New testing process | ||
| # Resting process |
Contributor
There was a problem hiding this comment.
Suggested change
| # Resting process | |
| # Testing process |
Contributor
There was a problem hiding this comment.
I mean I could do with a good rest 🤣
Contributor
There was a problem hiding this comment.
We have a sub-header below that is also "Testing process"... should this just say "Test" or something like "Unit Testing module"
Contributor
There was a problem hiding this comment.
We're also missing mention of the dependency to add to the project now...
This module provides a simple unit testing framework for your Orbit [ContainerHosts](https://orbit-mvi.org/dokka/orbit-core/org.orbitmvi.orbit/-container-host/).
testImplementation("org.orbit-mvi:orbit-test:<latest-version>")
mattmook
reviewed
May 22, 2024
website/docs/intro.md
Outdated
| @@ -18,7 +18,6 @@ think of it as MVVM+. | |||
| - [Android ViewModel](Android-ViewModel/overview.md) | |||
| - [Compose](Compose/overview.md) | |||
| - [Test](Test/new.md) | |||
Contributor
There was a problem hiding this comment.
wonder if really we should rename new.md to overview.md
mattmook
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup in preparation for Kotlin/WASM (See #204 for reference)
Also getting rid of docs for the old testing framework