#113: Add JS platform support#204
Closed
maik-mursall wants to merge 17 commits intoorbit-mvi:mainfrom
Closed
Conversation
|
Hot! I like! ❤️ |
Contributor
|
👀 |
Author
|
Hi @Rosomack :) Is there a chance for this PR getting reviewed? |
Contributor
|
Hi @maik-mursall , @mattmook and I had a look. Ultimately, we'd love to support JS, but the lack of
Thanks for taking the time to contribute! We'll keep you posted. |
Contributor
|
Closing - we will be adding in JS support shortly... watch this space 😃 |
Contributor
|
We've just merged #113 adding JS support. Expect a new release soon! |
Author
|
Hi @Rosomack, That's really great to hear. :D If I have time soon, I'll look at how you guys implemented it and see if I can learn from it. :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #113
runBlockingin shared code and replaced it with sensible coroutine-alternativesrunBlockingBreaking changes:
SimpleSyntaxExtensions.blockingIntentis now asuspend-functionintent-functions to besuspendas well, but this at least is the only one where it's necessary.Notes:
SimpleDslThreadingTestneed to be ignored by JS.withTimeoutandawaitCountcompletely block and never release