Skip to content

test(e2e): update spec-related constants to string literal#992

Merged
qweeah merged 4 commits into
oras-project:mainfrom
qweeah:e2e-string-literal
Jun 29, 2023
Merged

test(e2e): update spec-related constants to string literal#992
qweeah merged 4 commits into
oras-project:mainfrom
qweeah:e2e-string-literal

Conversation

@qweeah

@qweeah qweeah commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #721

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Jun 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #992 (740239b) into main (5e2cfe9) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          53       53           
  Lines        2792     2792           
=======================================
  Hits         2266     2266           
  Misses        356      356           
  Partials      170      170           

Comment thread test/e2e/internal/testdata/multi_arch/const.go Outdated
qweeah added 2 commits June 28, 2023 10:56
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit f9aec91 into oras-project:main Jun 29, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

e2e: update spec-related constants to string literal

3 participants