Skip to content

test(e2e): add test for pushing via absolute path#991

Merged
qweeah merged 31 commits into
oras-project:mainfrom
qweeah:e2e-path
Jun 29, 2023
Merged

test(e2e): add test for pushing via absolute path#991
qweeah merged 31 commits into
oras-project:mainfrom
qweeah:e2e-path

Conversation

@qweeah

@qweeah qweeah commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR adds E2E tests that validate the absolute path checking for oras push and oras attach. Depends on merging of #988

suganyas and others added 25 commits June 27, 2023 20:28
…ttach

Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…ttach

Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@shizhMSFT shizhMSFT added this to the v1.1.0 milestone Jun 28, 2023
suganyas and others added 4 commits June 28, 2023 19:50
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #991 (0c37583) into main (bf33bb7) will decrease coverage by 0.18%.
The diff coverage is 68.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
- Coverage   81.26%   81.08%   -0.18%     
==========================================
  Files          53       53              
  Lines        2776     2792      +16     
==========================================
+ Hits         2256     2264       +8     
- Misses        352      358       +6     
- Partials      168      170       +2     
Impacted Files Coverage Δ
cmd/oras/root/attach.go 82.50% <ø> (-0.15%) ⬇️
cmd/oras/root/pull.go 73.62% <0.00%> (-1.38%) ⬇️
cmd/oras/root/push.go 73.83% <ø> (-0.16%) ⬇️
cmd/oras/internal/option/packer.go 90.62% <81.25%> (-3.13%) ⬇️

... and 1 file with indirect coverage changes

@qweeah qweeah marked this pull request as ready for review June 28, 2023 10:58

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 5e2cfe9 into oras-project:main Jun 29, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

4 participants