test: add unit test for error scenario in internal/credential/store.go#982
Merged
Merged
Conversation
internal/credential/store.go
shizhMSFT
requested changes
Jun 20, 2023
5f33119 to
08cfc6f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 80.97% 81.08% +0.10%
==========================================
Files 57 57
Lines 2907 2907
==========================================
+ Hits 2354 2357 +3
+ Misses 378 376 -2
+ Partials 175 174 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qweeah
requested changes
Jun 29, 2023
shizhMSFT
approved these changes
Jun 29, 2023
735d053 to
70d6840
Compare
shizhMSFT
reviewed
Jun 29, 2023
shizhMSFT
requested changes
Jun 29, 2023
shizhMSFT
left a comment
Contributor
There was a problem hiding this comment.
Request changes for using t.TempDir for temp folder / file creation.
70d6840 to
9136a50
Compare
shizhMSFT
reviewed
Jun 30, 2023
9136a50 to
57011ec
Compare
shizhMSFT
reviewed
Jul 7, 2023
TerryHowe
reviewed
Jul 7, 2023
57011ec to
ea6e802
Compare
shizhMSFT
approved these changes
Jul 10, 2023
ea6e802 to
7d8ce2c
Compare
7d8ce2c to
88ae475
Compare
Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com>
Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com>
88ae475 to
70bac9c
Compare
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
…go` (oras-project#982) Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
…go` (oras-project#982) Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
pushed a commit
to shizhMSFT/oras
that referenced
this pull request
Aug 3, 2023
…go` (oras-project#982) Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com>
This was referenced Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a unit test file for
internal/credential/store.goto increase its code coverage from 78.57% to 100%.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
This PR is a small part of #972
Please check the following list: