chore: add snap for ubuntu by SamirPS · Pull Request #965 · oras-project/oras

SamirPS · 2023-06-03T19:43:13Z

What this PR does / why we need it:

This PR permit to create a snap for ubuntu.

On Linux install snapcraft

 sudo snap install snapcraft --classic

git clone this repository and put the snapcraft.yaml file i put on the PR in this folder.

And After

 snapcraft --debug

AT the end you will have a .Snap file install it with

 sudo snap install *.snap  --dangerous

You have installed the snap, now just run oras by typing oras

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

Does the affected code have corresponding tests, e.g. unit test, E2E test?
Does this change require a documentation update?
Does this introduce breaking changes that would require an announcement or bumping the major version?
Do all new files have an appropriate license header?

Signed-off-by: Samir Akarioh <samir.akarioh@canonical.com>

codecov-commenter · 2023-06-03T22:26:45Z

Codecov Report

Merging #965 (71e74a5) into main (57005b9) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files          53       53           
  Lines        2776     2776           
=======================================
  Hits         2253     2253           
  Misses        354      354           
  Partials      169      169

Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: SamirPS <samir.akarioh@canonical.com>

Signed-off-by: SamirPS <samir.akarioh@canonical.com>

TerryHowe

/lgtm

qweeah · 2023-06-05T00:58:30Z

Thanks @SamirPS for contributing. Should snapcraft --debug be added to Github actions so the snap of ORAS can be automatically updated when releasing?

SamirPS · 2023-06-05T08:45:21Z

@qweeah you can use theses actions to build and publish :

https://github.com/snapcore/action-build and https://github.com/snapcore/action-publish

Signed-off-by: SamirPS <samir.akarioh@canonical.com>

qweeah

nit: can you help format the header as suggested, thanks

qweeah · 2023-06-05T10:48:18Z

Another stupid question on the versioning: I followed the instructed steps and the snapcraft ends with generating a file named oras_v0.8.1+git377.3792315_amd64.snap. What does the v0.8.1 mean? I think this is not the version of built ORAS since I then do snap install and the generated version of oras is 1.0.0+unreleased.

Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: SamirPS <samir.akarioh@canonical.com>

SamirPS · 2023-06-05T11:03:51Z

It's not the version of oras it's come from the version:git name the snap like this oras_$(git_describe)_$(arch).snap

qweeah

LGTM

shizhMSFT

LGTM

shizhMSFT · 2023-06-05T11:09:24Z

@SamirPS Ready to be merged?

SamirPS · 2023-06-05T11:18:00Z

Not for now @shizhMSFT we have a little issue when registering the name oras with @FeynmanZhou

SamirPS · 2023-06-05T13:26:33Z

@shizhMSFT the MP can be merged now

shizhMSFT · 2023-06-05T13:47:25Z

@SamirPS The DCO check failed. Could you fix that?

SamirPS · 2023-06-05T13:51:03Z

yes i will do it

FeynmanZhou · 2023-06-05T13:59:29Z

Please wait for a while. I tested snap install oras but it looks like Snap gets the ORAS from the main branch. This is not stable. We need to use a specific tag or GitHub release for v1.0.0

 oras version
Version:        1.0.0+unreleased
Go version:     go1.20.4
Git commit:     dd6865a980650e4ff2eca2db771f7772a73e2cb3
Git tree state: dirty

SamirPS · 2023-06-05T14:08:40Z

@FeynmanZhou now i use the tag and pinpoint the version on the snapcraft.yaml file

samir@samir-Laptop:~/testoras/oras$ oras version
Version:        1.0.0
Go version:     go1.20.4
Git commit:     b58e7b910ca556973d111e9bd734a71baef03db2
Git tree state: clean

Signed-off-by: Samir Akarioh <samir.akarioh@canonical.com>

Signed-off-by: SamirPS <samir.akarioh@canonical.com>

SamirPS · 2023-06-05T17:17:51Z

This snapcraft build snap for amd64,arm64 and s390x

Signed-off-by: Samir Akarioh <samir.akarioh@canonical.com> Signed-off-by: SamirPS <samir.akarioh@canonical.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: Billy Zha <jinzha1@microsoft.com>

SamirPS requested review from SteveLasker, TerryHowe, qweeah, sajayantony and shizhMSFT as code owners June 3, 2023 19:43

add snap for ubuntu

e6e0e8f

Signed-off-by: Samir Akarioh <samir.akarioh@canonical.com>

This was referenced Jun 3, 2023

Onboard ORAS CLI to Snap for Ubuntu installation and provide guide oras-project/oras-www#185

Closed

Explain how to install oras snap oras-project/oras-www#188

Merged

TerryHowe reviewed Jun 4, 2023

View reviewed changes

Comment thread snapcraft.yaml Outdated

Comment thread snapcraft.yaml Outdated

SamirPS and others added 2 commits June 4, 2023 14:24

Update snapcraft.yaml

aaba60f

Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: SamirPS <samir.akarioh@canonical.com>

Update snapcraft.yaml

eff6450

Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: SamirPS <samir.akarioh@canonical.com>

SamirPS requested a review from TerryHowe June 4, 2023 12:24

TerryHowe reviewed Jun 4, 2023

View reviewed changes

Comment thread snapcraft.yaml

Update snapcraft.yaml

94ead94

Signed-off-by: SamirPS <samir.akarioh@canonical.com>

TerryHowe approved these changes Jun 4, 2023

View reviewed changes

qweeah requested changes Jun 5, 2023

View reviewed changes

Comment thread snapcraft.yaml

Update snapcraft.yaml

9e57300

Signed-off-by: SamirPS <samir.akarioh@canonical.com>

SamirPS requested a review from qweeah June 5, 2023 08:46

qweeah requested changes Jun 5, 2023

View reviewed changes

Comment thread snapcraft.yaml

qweeah reviewed Jun 5, 2023

View reviewed changes

Comment thread snapcraft.yaml

qweeah and others added 2 commits June 5, 2023 18:48

Merge branch 'main' into snapcraft

166badc

Update snapcraft.yaml

dd6865a

Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: SamirPS <samir.akarioh@canonical.com>

qweeah approved these changes Jun 5, 2023

View reviewed changes

shizhMSFT changed the title ~~add snap for ubuntu~~ chore: add snap for ubuntu Jun 5, 2023

shizhMSFT approved these changes Jun 5, 2023

View reviewed changes

Samir Akarioh added 2 commits June 5, 2023 16:46

change grade to stable and use the version

83e81ec

Signed-off-by: Samir Akarioh <samir.akarioh@canonical.com>

Update snap.yml

71e74a5

Signed-off-by: SamirPS <samir.akarioh@canonical.com>

qweeah merged commit 3ff15bb into oras-project:main Jun 6, 2023

This was referenced Jul 5, 2023

Vote for releasing v1.1.0-rc.1 #1002

Closed

bump: tag and release ORAS CLI v1.1.0-rc.1 #1016

Merged

ZhongRuoyu mentioned this pull request Aug 7, 2023

oras 1.0.1 Homebrew/homebrew-core#138923

Merged

FeynmanZhou mentioned this pull request Aug 29, 2023

Using ORAS from snap can't authenticate with gcloud credential helper #1079

Closed

1 task

Conversation

SamirPS commented Jun 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jun 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TerryHowe left a comment

Choose a reason for hiding this comment

Uh oh!

qweeah commented Jun 5, 2023

Uh oh!

Uh oh!

SamirPS commented Jun 5, 2023

Uh oh!

qweeah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

qweeah commented Jun 5, 2023

Uh oh!

SamirPS commented Jun 5, 2023

Uh oh!

qweeah left a comment

Choose a reason for hiding this comment

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

shizhMSFT commented Jun 5, 2023

Uh oh!

SamirPS commented Jun 5, 2023

Uh oh!

SamirPS commented Jun 5, 2023

Uh oh!

shizhMSFT commented Jun 5, 2023

Uh oh!

SamirPS commented Jun 5, 2023

Uh oh!

FeynmanZhou commented Jun 5, 2023

Uh oh!

SamirPS commented Jun 5, 2023

Uh oh!

SamirPS commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SamirPS commented Jun 3, 2023 •

edited

Loading

codecov-commenter commented Jun 3, 2023 •

edited

Loading