Skip to content

fix: correct spec flag description#964

Merged
shizhMSFT merged 2 commits into
oras-project:mainfrom
qweeah:fix-spec
May 31, 2023
Merged

fix: correct spec flag description#964
shizhMSFT merged 2 commits into
oras-project:mainfrom
qweeah:fix-spec

Conversation

@qweeah

@qweeah qweeah commented May 31, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR fixes a minor bug for the spec flag value checking.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #897

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented May 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #964 (3cd48fb) into main (cd7319c) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   80.94%   81.08%   +0.14%     
==========================================
  Files          53       53              
  Lines        2776     2776              
==========================================
+ Hits         2247     2251       +4     
+ Misses        360      356       -4     
  Partials      169      169              
Impacted Files Coverage Δ
cmd/oras/internal/option/spec.go 100.00% <100.00%> (+14.81%) ⬆️

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit f4a7aed into oras-project:main May 31, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid --distribution-spec flag returns wrong error information

3 participants