Skip to content

build: using cross compilation in docker build#938

Merged
shizhMSFT merged 1 commit into
oras-project:mainfrom
northtyphoon:corss-compilation
Apr 28, 2023
Merged

build: using cross compilation in docker build#938
shizhMSFT merged 1 commit into
oras-project:mainfrom
northtyphoon:corss-compilation

Conversation

@northtyphoon

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The change follows https://docs.docker.com/build/guide/multi-platform/#build-using-cross-compilation to switch oras docker release build to cross-compilation. It boosts the build performance by ~7x.

Existing using emulation: 12m 9s.
New using cross-compilation : 1m 39s

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test? Yes
  • Does this change require a documentation update? No
  • Does this introduce breaking changes that would require an announcement or bumping the major version? No
  • Do all new files have an appropriate license header? N/A

Signed-off-by: Bin Du <bindu@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 776041f into oras-project:main Apr 28, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants