Skip to content

feat: use oras-credential-go to do auth#932

Merged
shizhMSFT merged 7 commits into
oras-project:mainfrom
qweeah:try-ocreds
Apr 27, 2023
Merged

feat: use oras-credential-go to do auth#932
shizhMSFT merged 7 commits into
oras-project:mainfrom
qweeah:try-ocreds

Conversation

@qweeah

@qweeah qweeah commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #931

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as draft April 24, 2023 09:21
@codecov-commenter

codecov-commenter commented Apr 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #932 (97871d1) into main (07fbec8) will increase coverage by 0.71%.
The diff coverage is 92.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   80.30%   81.01%   +0.71%     
==========================================
  Files          53       53              
  Lines        2853     2776      -77     
==========================================
- Hits         2291     2249      -42     
+ Misses        383      358      -25     
+ Partials      179      169      -10     
Impacted Files Coverage Δ
cmd/oras/root/login.go 72.22% <66.66%> (+4.18%) ⬆️
cmd/oras/internal/option/remote.go 79.00% <100.00%> (+2.28%) ⬆️
cmd/oras/root/logout.go 77.77% <100.00%> (+6.81%) ⬆️
internal/credential/store.go 78.57% <100.00%> (+7.73%) ⬆️

... and 1 file with indirect coverage changes

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review April 24, 2023 09:52
qweeah added 3 commits April 24, 2023 18:58
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread cmd/oras/root/login.go Outdated
Comment thread internal/credential/store.go Outdated
Comment thread internal/credential/store.go Outdated
Comment thread internal/credential/store.go
Comment thread cmd/oras/root/login.go Outdated
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Comment thread internal/credential/store.go Outdated
Comment thread internal/credential/store.go Outdated
Comment thread internal/credential/store.go Outdated
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread go.sum

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a54a99d into oras-project:main Apr 27, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integrated with oras-credential-go

5 participants