Skip to content

refactor: replace terminal package used by oras login#910

Merged
qweeah merged 13 commits into
oras-project:mainfrom
qweeah:update-term
Apr 10, 2023
Merged

refactor: replace terminal package used by oras login#910
qweeah merged 13 commits into
oras-project:mainfrom
qweeah:update-term

Conversation

@qweeah

@qweeah qweeah commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR updates the underlying package of oras login with minor refactoring.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #908

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

shizhMSFT
shizhMSFT reviewed Mar 29, 2023
View reviewed changes
Comment thread cmd/oras/login.go Outdated
Comment thread cmd/oras/login.go Outdated
@codecov-commenter

codecov-commenter commented Mar 29, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #910 (3f93344) into main (981e419) will increase coverage by 0.90%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
+ Coverage   78.76%   79.67%   +0.90%     
==========================================
  Files          52       53       +1     
  Lines        2840     2853      +13     
==========================================
+ Hits         2237     2273      +36     
+ Misses        429      399      -30     
- Partials      174      181       +7
Impacted Files Coverage Δ
cmd/oras/root/login.go 68.04% <66.66%> (+24.04%) ⬆️
internal/io/io.go 87.50% <87.50%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah qweeah requested a review from shizhMSFT March 29, 2023 09:19
TerryHowe
TerryHowe reviewed Mar 29, 2023
View reviewed changes
Comment thread cmd/oras/login.go
TerryHowe
TerryHowe approved these changes Mar 29, 2023
View reviewed changes

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah force-pushed the update-term branch 2 times, most recently from 824398a to 84c1f24 Compare March 30, 2023 03:23
shizhMSFT
shizhMSFT reviewed Mar 30, 2023
View reviewed changes
Comment thread internal/io/io.go
Comment thread internal/io/io.go
Comment thread internal/io/io.go Outdated
Comment thread cmd/oras/root/login.go
Comment thread cmd/oras/root/login.go Outdated
shizhMSFT
shizhMSFT requested changes Mar 30, 2023
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

@qweeah qweeah mentioned this pull request Apr 6, 2023
Closed
4 tasks
qweeah added 11 commits April 10, 2023 06:37
@qweeah
refactor: replace terminal package
841c167 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add e2e tests
31b3dc7 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
9535df2 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
modify readLine only
ce5314a 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
read until no more
000e251 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix bug when reading line
2fc7c41 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
implement with self-implemented scanf
d5b541b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
bug fix
f51fb64 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
refactor and add tests
d51d1f7 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comments and add test
88f88e3 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add comments
0612150 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
change package name
c7426ad 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT reviewed Apr 10, 2023
View reviewed changes
Comment thread internal/io/io.go
@qweeah
resolve comment
3f93344 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Apr 10, 2023
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit f005e2f into oras-project:main Apr 10, 2023
This was referenced Jul 5, 2023
Closed
Merged
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
@qweeah @shizhMSFT
refactor: replace terminal package used by oras login (oras-project…
ec93643 
…#910)

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update github.com/moby/term to golang.org/x/term

4 participants

@qweeah @codecov-commenter @TerryHowe @shizhMSFT