Skip to content

test: generate coverage profile during e2e tests#903

Merged
qweeah merged 13 commits into
oras-project:mainfrom
qweeah:e2e-cov
Apr 6, 2023
Merged

test: generate coverage profile during e2e tests#903
qweeah merged 13 commits into
oras-project:mainfrom
qweeah:e2e-cov

Conversation

@qweeah

@qweeah qweeah commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR updates E2E test infra to generate test coverage profile when running e2e test. If the build is triggered by tagging and the tag starts with v (a release), e2e test will be ran directly on non-instrumented application.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #900.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah qweeah marked this pull request as draft March 23, 2023 10:27
@qweeah qweeah marked this pull request as ready for review March 23, 2023 11:14
@codecov-commenter

codecov-commenter commented Mar 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #903 (56adf95) into main (60eec26) will increase coverage by 10.96%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main     #903       +/-   ##
===========================================
+ Coverage   67.79%   78.76%   +10.96%     
===========================================
  Files          22       52       +30     
  Lines         860     2839     +1979     
===========================================
+ Hits          583     2236     +1653     
- Misses        232      429      +197     
- Partials       45      174      +129     

see 36 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread test/e2e/scripts/e2e.sh

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qweeah added 12 commits April 6, 2023 08:56
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 55751b8 into oras-project:main Apr 6, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

end-to-end test generated coverage profile

4 participants