Skip to content

refactor: unify command contexts#899

Merged
shizhMSFT merged 11 commits into
oras-project:mainfrom
qweeah:standardize-context
Apr 6, 2023
Merged

refactor: unify command contexts#899
shizhMSFT merged 11 commits into
oras-project:mainfrom
qweeah:standardize-context

Conversation

@qweeah

@qweeah qweeah commented Mar 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Makes all oras commands executed based on the same context passed from root command. Depends on merging of #825

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #824

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah qweeah marked this pull request as draft March 23, 2023 06:45
@codecov-commenter

codecov-commenter commented Mar 23, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #899 (cb0bbd3) into main (60eec26) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   67.79%   67.63%   -0.16%     
==========================================
  Files          22       22              
  Lines         860      862       +2     
==========================================
  Hits          583      583              
- Misses        232      234       +2     
  Partials       45       45
Impacted Files Coverage Δ
cmd/oras/internal/option/common.go 60.00% <0.00%> (-40.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

TerryHowe
TerryHowe reviewed Mar 23, 2023
View reviewed changes
Comment thread cmd/oras/internal/option/common.go Outdated
@qweeah qweeah force-pushed the standardize-context branch from ddf80ab to f965cd6 Compare March 30, 2023 02:56
@qweeah qweeah marked this pull request as ready for review March 30, 2023 02:56
@qweeah qweeah force-pushed the standardize-context branch from f965cd6 to d37714d Compare March 30, 2023 15:30
TerryHowe
TerryHowe approved these changes Apr 2, 2023
View reviewed changes

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Apr 6, 2023
View reviewed changes
Comment thread cmd/oras/root/attach.go Outdated
Comment thread cmd/oras/root/attach.go Outdated
@qweeah qweeah force-pushed the standardize-context branch from d37714d to 153275d Compare April 6, 2023 02:00
qweeah added 9 commits April 6, 2023 02:01
@qweeah
refactor: move commands to root package
bec7973 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix main package naming
d8fc08b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
undo changes
a6442f0 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
358683f 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
refactor: use unified context in all commands
456c9fd 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
hide common logging options
98c7fa8 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
rename
df352df 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
remove example file
4542c89 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
nit: update param order
e77ec04 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah force-pushed the standardize-context branch from 153275d to e77ec04 Compare April 6, 2023 02:01
qweeah added 2 commits April 6, 2023 02:02
@qweeah
fix build error
808b52e 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comments
cb0bbd3 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Apr 6, 2023
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 3341fac into oras-project:main Apr 6, 2023
This was referenced Jul 5, 2023
Closed
Closed
Merged
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
@qweeah @shizhMSFT
refactor: unify command contexts (oras-project#899)
a335648 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qweeah @codecov-commenter @TerryHowe @shizhMSFT