test: add test coverage for cmd/oras/internal/display/metadata/text/blob* handlers#1861
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add test coverage for cmd/oras/internal/display/metadata/text/blob*
Add test coverage for cmd/oras/internal/display/metadata/text/blob* handlers
Sep 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1861 +/- ##
==========================================
+ Coverage 85.33% 85.36% +0.02%
==========================================
Files 143 143
Lines 6743 6743
==========================================
+ Hits 5754 5756 +2
+ Misses 703 701 -2
Partials 286 286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: TerryHowe <104113+TerryHowe@users.noreply.github.com>
c175716 to
9f224d3
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the blob metadata text handlers in the ORAS CLI that were previously untested. The handlers are responsible for formatting text output during blob push and delete operations.
- Adds complete test coverage for
BlobPushHandlerincluding constructor validation, output formatting, and digest display - Adds complete test coverage for
BlobDeleteHandlerincluding constructor validation and output formatting for missing/deleted blobs - Tests cover various scenarios including registry/OCI layout targets, different reference formats, and error handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| blob_push_test.go | Adds comprehensive tests for BlobPushHandler covering constructor, OnBlobPushed, and Render methods |
| blob_delete_test.go | Adds comprehensive tests for BlobDeleteHandler covering constructor, OnBlobMissing, and OnBlobDeleted methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shizhMSFT
reviewed
Sep 23, 2025
…bcd1234 Co-authored-by: shizhMSFT <32161882+shizhMSFT@users.noreply.github.com>
Contributor
|
I guess this requires review from @Wwwsylvia as the copilot added commits on my behalf. |
ManishhDev
pushed a commit
to ManishhDev/oras
that referenced
this pull request
Oct 22, 2025
…lob* handlers (oras-project#1861) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TerryHowe <104113+TerryHowe@users.noreply.github.com> Co-authored-by: shizhMSFT <32161882+shizhMSFT@users.noreply.github.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: ManishhDev <codermanishhh@gmail.com>
ManishhDev
pushed a commit
to ManishhDev/oras
that referenced
this pull request
Oct 22, 2025
…lob* handlers (oras-project#1861) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TerryHowe <104113+TerryHowe@users.noreply.github.com> Co-authored-by: shizhMSFT <32161882+shizhMSFT@users.noreply.github.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: ManishhDev <codermanishhh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive test coverage for the blob metadata text handlers that were previously untested. The blob handlers are responsible for formatting text output during blob push and delete operations in the ORAS CLI.
Changes Made
New Test Files Added
blob_push_test.go- Complete test coverage forBlobPushHandlerblob_delete_test.go- Complete test coverage forBlobDeleteHandlerTest Coverage Achieved
All blob handler functions now have 100% test coverage:
BlobPushHandler:
NewBlobPushHandler- Constructor validationOnBlobPushed- Output formatting for successful blob pushesRender- Digest display formattingBlobDeleteHandler:
NewBlobDeleteHandler- Constructor validationOnBlobMissing- Output formatting when blob is missingOnBlobDeleted- Output formatting for successful blob deletionsTest Scenarios Covered
The tests follow the existing project patterns and conventions, using the same testing infrastructure as other handlers in the package (like
push_test.goandrestore_test.go).Recent Updates
sha256:abcd1234with real digestsha256:9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08in blob_delete_test.goFixes #1860.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.