Skip to content

fix: discover json format should show referrers field when no referrer is found#1731

Merged
TerryHowe merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:fix-no-referrer
May 20, 2025
Merged

fix: discover json format should show referrers field when no referrer is found#1731
TerryHowe merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:fix-no-referrer

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented May 14, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1715

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

…r is found

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Xiaoxuan Wang added 2 commits May 14, 2025 16:28
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov

codecov Bot commented May 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (33a9b67) to head (c43c505).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1731   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         129      129           
  Lines        5761     5762    +1     
=======================================
+ Hits         4904     4905    +1     
  Misses        611      611           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia

Copy link
Copy Markdown
Member

@wangxiaoxuan273 Could you update the branch?

@TerryHowe TerryHowe merged commit e23a0d5 into oras-project:main May 20, 2025
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
…r is found (oras-project#1731)

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Co-authored-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
@wangxiaoxuan273 wangxiaoxuan273 deleted the fix-no-referrer branch August 25, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oras discover --format json should show an empty referrers list if no referrer found

3 participants