Skip to content

refactor: rename Target AnnotatedReference method#1726

Merged
qweeah merged 1 commit into
oras-project:mainfrom
TerryHowe:rename-annotated-reference-method
May 14, 2025
Merged

refactor: rename Target AnnotatedReference method#1726
qweeah merged 1 commit into
oras-project:mainfrom
TerryHowe:rename-annotated-reference-method

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Every time I see this method, I wonder what it does. This name makes it clear.

@codecov

codecov Bot commented May 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (d1c2c23) to head (6866a57).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/root/manifest/index/create.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1726   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files         129      129           
  Lines        5764     5764           
=======================================
  Hits         4907     4907           
  Misses        611      611           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions.

Comment thread cmd/oras/internal/display/metadata/text/attach.go Outdated
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the rename-annotated-reference-method branch from 47e1c4f to 6866a57 Compare May 13, 2025 11:05

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit f74a9f4 into oras-project:main May 14, 2025
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants