Skip to content

refactor: move --no-tty out of option.Common#1699

Merged
Wwwsylvia merged 15 commits into
oras-project:mainfrom
wangxiaoxuan273:discover-help-doc
Apr 24, 2025
Merged

refactor: move --no-tty out of option.Common#1699
Wwwsylvia merged 15 commits into
oras-project:mainfrom
wangxiaoxuan273:discover-help-doc

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR moves notty out of option.Common and changes the descriptions of the no-tty flag.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1630

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@codecov

codecov Bot commented Apr 18, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (16e4682) to head (571c8a6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/internal/option/terminal.go 80.00% 2 Missing and 1 partial ⚠️
cmd/oras/root/blob/push.go 40.00% 2 Missing and 1 partial ⚠️
cmd/oras/root/blob/fetch.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   84.81%   84.66%   -0.15%     
==========================================
  Files         126      127       +1     
  Lines        5702     5718      +16     
==========================================
+ Hits         4836     4841       +5     
- Misses        616      624       +8     
- Partials      250      253       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Xiaoxuan Wang added 3 commits April 18, 2025 16:56
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Xiaoxuan Wang added 2 commits April 21, 2025 14:30
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Comment thread cmd/oras/internal/option/notty.go Outdated
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a thought

Comment thread cmd/oras/internal/option/tty.go Outdated
Comment thread cmd/oras/internal/option/tty.go Outdated
Comment thread cmd/oras/internal/option/tty.go Outdated
Comment thread cmd/oras/internal/option/tty.go Outdated
Comment thread cmd/oras/internal/option/tty.go Outdated
Comment thread cmd/oras/internal/option/tty.go
Comment thread cmd/oras/internal/option/tty.go Outdated
Comment thread cmd/oras/root/pull.go Outdated
Comment thread cmd/oras/internal/option/tty.go Outdated
Xiaoxuan Wang added 3 commits April 24, 2025 17:02
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Comment thread cmd/oras/internal/option/terminal.go Outdated
Comment thread cmd/oras/root/attach.go Outdated
Comment thread cmd/oras/root/pull.go
Xiaoxuan Wang added 2 commits April 24, 2025 17:32
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xiaoxuan Wang added 2 commits April 24, 2025 18:38
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@Wwwsylvia Wwwsylvia merged commit 3a02c88 into oras-project:main Apr 24, 2025
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 deleted the discover-help-doc branch August 25, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect description of the --no-tty flag for oras discover

3 participants