Skip to content

fix: packer decode json lint failure#1688

Merged
TerryHowe merged 6 commits into
oras-project:mainfrom
TerryHowe:lint-packer-decode-json
May 8, 2025
Merged

fix: packer decode json lint failure#1688
TerryHowe merged 6 commits into
oras-project:mainfrom
TerryHowe:lint-packer-decode-json

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Attempt to fix options packer decode json lint failure with tests.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Apr 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (bda034e) to head (4ce3ed1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   84.80%   84.81%   +0.01%     
==========================================
  Files         127      127              
  Lines        5718     5722       +4     
==========================================
+ Hits         4849     4853       +4     
  Misses        619      619              
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread cmd/oras/internal/option/packer.go Outdated
TerryHowe and others added 2 commits April 12, 2025 12:01
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Comment thread cmd/oras/internal/option/packer.go Outdated
TerryHowe and others added 2 commits April 15, 2025 12:05
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe requested a review from Wwwsylvia May 6, 2025 12:15
@TerryHowe TerryHowe merged commit 00db5dc into oras-project:main May 8, 2025
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants