Skip to content

fix: explicitly ignore return for newest lint#1683

Merged
TerryHowe merged 2 commits into
oras-project:mainfrom
TerryHowe:deprecation-message
Apr 11, 2025
Merged

fix: explicitly ignore return for newest lint#1683
TerryHowe merged 2 commits into
oras-project:mainfrom
TerryHowe:deprecation-message

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Explicitly ignore return from this print for compatibility with newest version of lint. This message is sent to stderr and will not impact the important output of commands. We should care more for data output to stdout.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (27ee53f) to head (b44b5b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files         126      126           
  Lines        5683     5683           
=======================================
  Hits         4816     4816           
  Misses        617      617           
  Partials      250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe merged commit e5cf186 into oras-project:main Apr 11, 2025
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants