Skip to content

fix: unneeded error check#1680

Merged
Wwwsylvia merged 2 commits into
oras-project:mainfrom
TerryHowe:fix-unneeded-err-check
Apr 1, 2025
Merged

fix: unneeded error check#1680
Wwwsylvia merged 2 commits into
oras-project:mainfrom
TerryHowe:fix-unneeded-err-check

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This error check will always be false.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Mar 31, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (bd9c3da) to head (067bdd3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
+ Coverage   84.66%   84.77%   +0.11%     
==========================================
  Files         126      126              
  Lines        5685     5682       -3     
==========================================
+ Hits         4813     4817       +4     
+ Misses        621      615       -6     
+ Partials      251      250       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit cdd78ec into oras-project:main Apr 1, 2025
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe deleted the fix-unneeded-err-check branch September 11, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants