Skip to content

fix: staticcheck fails for embedded member#1676

Merged
Wwwsylvia merged 2 commits into
oras-project:mainfrom
TerryHowe:test-staticcheck-embedded
Apr 1, 2025
Merged

fix: staticcheck fails for embedded member#1676
Wwwsylvia merged 2 commits into
oras-project:mainfrom
TerryHowe:test-staticcheck-embedded

Conversation

@TerryHowe

@TerryHowe TerryHowe commented Mar 31, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

These embedded members fail staticcheck for newest lint because the embedded member cannot be extracted. This PR is for tests only. There is another PR for non-tests.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (71789eb) to head (8a26c68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1676   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files         126      126           
  Lines        5685     5685           
=======================================
  Hits         4815     4815           
  Misses        619      619           
  Partials      251      251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wwwsylvia Wwwsylvia merged commit bd9c3da into oras-project:main Apr 1, 2025
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe deleted the test-staticcheck-embedded branch September 11, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants