fix: update --add should add plain descriptor#1513
Merged
Conversation
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 118 118
Lines 4225 4228 +3
=======================================
+ Hits 3634 3637 +3
+ Misses 353 352 -1
- Partials 238 239 +1 ☔ View full report in Codecov by Sentry. |
qweeah
reviewed
Oct 14, 2024
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
qweeah
approved these changes
Oct 14, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestions
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Contributor
|
The code coverage is hard to increase since #1509 is still WIP. After #1509 is done, we can add a unified add function for both |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
oras manifest index update --addnow adds the original manifest descriptor, and which may include the annotations. The command should add the plain descriptor.oras manifest index update --mergestill adds the original manifest descriptors. The annotations may be meaningful under merge scenarios.