Skip to content

refactor: status, metadata and content handlers for manifest index commands#1509

Merged
qweeah merged 28 commits into
oras-project:mainfrom
wangxiaoxuan273:output-output
Nov 14, 2024
Merged

refactor: status, metadata and content handlers for manifest index commands#1509
qweeah merged 28 commits into
oras-project:mainfrom
wangxiaoxuan273:output-output

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Sep 24, 2024 •
edited by qweeah
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Implements output handlers for manifest index commands.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1503

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Xiaoxuan Wang added 5 commits September 24, 2024 10:39
create handler
182c8f0 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
compiles
495ab7e 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
align update output with tag
d81fd04 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
align update output with digest
f807af8 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
refinement
9134a8f 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 changed the title Output output refactor: status, metadata and content handlers for manifest index commands Sep 24, 2024
@codecov

codecov Bot commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.52427% with 36 lines in your changes missing coverage. Please review.

Project coverage is 83.96%. Comparing base (b4be9a6) to head (2f1dd59).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/root/manifest/index/update.go 61.11% 14 Missing and 7 partials ⚠️
cmd/oras/root/manifest/index/create.go 50.00% 10 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   83.99%   83.96%   -0.04%     
==========================================
  Files         118      119       +1     
  Lines        5174     5306     +132     
==========================================
+ Hits         4346     4455     +109     
- Misses        588      604      +16     
- Partials      240      247       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Xiaoxuan Wang added 3 commits September 24, 2024 17:04
added error checks
5104cc9 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
content handlers
a9b1164 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
refinement
4d144be 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 marked this pull request as ready for review September 25, 2024 05:57
qweeah
qweeah reviewed Sep 25, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/content/manifest_index.go
fix pretty with file output
4d18845 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
qweeah
qweeah requested changes Sep 26, 2024
View reviewed changes
Comment thread cmd/oras/root/manifest/index/create.go Outdated
Comment thread cmd/oras/internal/display/content/manifest_index.go Outdated
Comment thread cmd/oras/internal/display/metadata/text/manifest_index_create.go Outdated
Comment thread cmd/oras/internal/display/metadata/discard.go Outdated
Comment thread cmd/oras/internal/display/metadata/discard.go Outdated
Comment thread cmd/oras/internal/display/metadata/interface.go Outdated
Comment thread cmd/oras/internal/display/status/interface.go Outdated
Comment thread cmd/oras/internal/display/status/interface.go Outdated
Comment thread cmd/oras/internal/display/status/interface.go Outdated
qweeah
qweeah reviewed Sep 26, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/status/interface.go
qweeah
qweeah requested changes Sep 26, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/handler.go
Comment thread cmd/oras/root/manifest/index/update.go Outdated
TerryHowe
TerryHowe reviewed Sep 27, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/content/manifest_index.go Outdated
Comment thread cmd/oras/internal/display/handler.go
Comment thread cmd/oras/internal/display/status/text.go Outdated
Comment thread cmd/oras/internal/display/status/text.go Outdated
Comment thread cmd/oras/root/manifest/index/create.go Outdated
Comment thread cmd/oras/root/manifest/index/create.go Outdated
Comment thread cmd/oras/root/manifest/index/update.go Outdated
discard parameter naming
8ea9b14 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
wangxiaoxuan273
wangxiaoxuan273 commented Oct 9, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/status/text.go Outdated
wangxiaoxuan273
wangxiaoxuan273 commented Oct 9, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/status/text.go Outdated
Xiaoxuan Wang added 5 commits October 9, 2024 15:01
resolved comments
16cf5ab 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
manifest ref fetch handler
c56fdec 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
reset pretty in handler construction
49091a2 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
resolved comments
66249a8 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Merge branch 'main' into output-output
6e3b09a
qweeah
qweeah requested changes Oct 11, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/metadata/text/manifest_index.go Outdated
Comment thread cmd/oras/internal/display/metadata/interface.go Outdated
Comment thread cmd/oras/internal/display/handler.go Outdated
Comment thread cmd/oras/internal/display/status/utils.go
Comment thread cmd/oras/root/manifest/index/create.go Outdated
shizhMSFT
shizhMSFT reviewed Oct 14, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/content/discard.go Outdated
Comment thread cmd/oras/internal/display/content/manifest_index.go
Comment thread cmd/oras/internal/display/content/manifest_index.go Outdated
Comment thread cmd/oras/internal/display/metadata/discard.go Outdated
Comment thread cmd/oras/internal/display/metadata/interface.go Outdated
Comment thread cmd/oras/internal/display/status/interface.go Outdated
Comment thread cmd/oras/internal/display/status/utils.go
Xiaoxuan Wang added 2 commits October 14, 2024 14:55
resolved billy's comment
851701d 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Merge branch 'main' into output-output
3a2fb99
@qweeah qweeah mentioned this pull request Oct 14, 2024
Merged
@wangxiaoxuan273 wangxiaoxuan273 mentioned this pull request Oct 21, 2024
Closed
@wangxiaoxuan273

wangxiaoxuan273 commented Oct 21, 2024

Copy link
Copy Markdown
Contributor Author

As per offline discussion, added, merged, removed, pushed, packed should exist in both status and metadata output. And Status output is needed in the PR, metadata output can be added in a future pr when needed.

Xiaoxuan Wang added 2 commits October 21, 2024 15:24
resolved shiwei's comments
a7a88d8 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Merge branch 'main' into output-output
f6c0790 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
shizhMSFT
shizhMSFT reviewed Oct 28, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/content/manifest_index.go
Comment thread cmd/oras/internal/display/handler.go Outdated
Comment thread cmd/oras/internal/display/handler.go Outdated
Comment thread cmd/oras/internal/display/status/text.go Outdated
Comment thread cmd/oras/internal/display/status/text.go Outdated
Comment thread cmd/oras/internal/display/status/text.go Outdated
Xiaoxuan Wang added 7 commits October 29, 2024 09:46
resolved comments
e262d51 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
add discard test coverage
3a9bb0a 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
increase test coverage
394f907 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
increase coverage
b20b059 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
increase coverage
20ac24b 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
increase test coverage
97ba0a1 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Merge branch 'main' into output-output
b3709ff
@qweeah qweeah self-requested a review November 12, 2024 02:51
qweeah
qweeah reviewed Nov 12, 2024
View reviewed changes
Comment thread cmd/oras/root/manifest/index/update_test.go Outdated
Xiaoxuan Wang added 2 commits November 12, 2024 12:56
resolved comments
fbedb63 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Merge branch 'main' into output-output
2f1dd59
shizhMSFT
shizhMSFT approved these changes Nov 13, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qweeah
qweeah approved these changes Nov 14, 2024
View reviewed changes

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit e6a3eee into oras-project:main Nov 14, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the output-output branch November 27, 2024 06:45
@wangxiaoxuan273 wangxiaoxuan273 mentioned this pull request Dec 4, 2024
Merged
4 tasks
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@qweeah qweeah qweeah approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

oras manifest index create/update --output - should hide other stdout output

4 participants

@wangxiaoxuan273 @TerryHowe @qweeah @shizhMSFT