Skip to content

refactor: simplify track reader manager and messenger use#1474

Closed
TerryHowe wants to merge 4 commits into
oras-project:mainfrom
TerryHowe:progress-manager
Closed

refactor: simplify track reader manager and messenger use#1474
TerryHowe wants to merge 4 commits into
oras-project:mainfrom
TerryHowe:progress-manager

Conversation

@TerryHowe

@TerryHowe TerryHowe commented Aug 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

If we just pass the messenger to reader, it will be a lot easier to test these packages.

Partial: #1461
Partial: #1449

@TerryHowe TerryHowe force-pushed the progress-manager branch 4 times, most recently from 0aedce4 to 83dc8ec Compare August 14, 2024 15:14
@codecov

codecov Bot commented Aug 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.37%. Comparing base (8a31d9b) to head (e50ebfd).
⚠️ Report is 113 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/internal/display/status/track/target.go 64.70% 4 Missing and 2 partials ⚠️
cmd/oras/root/blob/fetch.go 66.66% 3 Missing and 1 partial ⚠️
cmd/oras/root/blob/push.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   84.34%   84.37%   +0.02%     
==========================================
  Files         120      121       +1     
  Lines        5449     5509      +60     
==========================================
+ Hits         4596     4648      +52     
- Misses        606      612       +6     
- Partials      247      249       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TerryHowe TerryHowe force-pushed the progress-manager branch 9 times, most recently from b7b0a9a to d2ffbe7 Compare August 16, 2024 21:06
@TerryHowe TerryHowe marked this pull request as draft August 19, 2024 18:10
This was referenced Sep 28, 2024
Closed
Open
@TerryHowe TerryHowe force-pushed the progress-manager branch 3 times, most recently from c1f4e72 to 04ede71 Compare September 30, 2024 14:50
@TerryHowe TerryHowe marked this pull request as ready for review September 30, 2024 14:59
@TerryHowe
refactor: simplify reader with manager and messenger
f2066cc 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe mentioned this pull request Nov 25, 2024
Merged
4 tasks
@github-actions

github-actions Bot commented Dec 22, 2024

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions Bot added the stale Inactive issues or pull requests label Dec 22, 2024
@TerryHowe TerryHowe removed the stale Inactive issues or pull requests label Dec 22, 2024
@TerryHowe TerryHowe requested a review from Wwwsylvia as a code owner January 14, 2025 18:18
@github-actions

github-actions Bot commented Mar 1, 2025

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions Bot added the stale Inactive issues or pull requests label Mar 1, 2025
@TerryHowe

TerryHowe commented Mar 1, 2025

Copy link
Copy Markdown
Member Author

I think I still want to pull something out of this.

@TerryHowe TerryHowe removed the stale Inactive issues or pull requests label Mar 1, 2025
@TerryHowe

TerryHowe commented Apr 2, 2025

Copy link
Copy Markdown
Member Author

Partially handled by #1624 and #1524

@github-actions

github-actions Bot commented May 18, 2025

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions Bot added the stale Inactive issues or pull requests label May 18, 2025
@TerryHowe TerryHowe removed the stale Inactive issues or pull requests label May 18, 2025
@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions Bot added the stale Inactive issues or pull requests label Jul 3, 2025
@TerryHowe TerryHowe removed the stale Inactive issues or pull requests label Jul 3, 2025
@TerryHowe TerryHowe closed this Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@qweeah qweeah Awaiting requested review from qweeah

@Wwwsylvia Wwwsylvia Awaiting requested review from Wwwsylvia Wwwsylvia is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TerryHowe