Skip to content

refactor: improve metadata handler of oras cp#1624

Merged
shizhMSFT merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:cp-handlers
Feb 19, 2025
Merged

refactor: improve metadata handler of oras cp#1624
shizhMSFT merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:cp-handlers

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1548 , which was falsely marked as closed
Part of #1542

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@codecov

codecov Bot commented Feb 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (ccd9f3f) to head (2b8e4b6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/root/cp.go 25.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
- Coverage   84.37%   84.33%   -0.05%     
==========================================
  Files         120      120              
  Lines        5460     5464       +4     
==========================================
+ Hits         4607     4608       +1     
- Misses        606      608       +2     
- Partials      247      248       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread cmd/oras/root/cp.go Outdated
Comment thread cmd/oras/internal/display/metadata/interface.go Outdated
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 changed the title improve metadata handler of oras cp refactor: improve metadata handler of oras cp Feb 19, 2025
Xiaoxuan Wang added 2 commits February 19, 2025 16:31
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor oras cp to use handlers for command output

2 participants