fix: variable name conflicts with built in function#1448
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
+ Coverage 85.47% 85.52% +0.05%
==========================================
Files 108 108
Lines 3827 3827
==========================================
+ Hits 3271 3273 +2
+ Misses 332 331 -1
+ Partials 224 223 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
0dfa744 to
958e7e6
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
qweeah
reviewed
Jul 19, 2024
qweeah
approved these changes
Jul 19, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestions.
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Contributor
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The variable name
lenconflicts with the built in. This will simplify my other PR a bit as well.