refactor: Isolate progress channel in Messenger#1447
Merged
Conversation
2fe90e3 to
aaee187
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
- Coverage 85.47% 85.42% -0.06%
==========================================
Files 108 109 +1
Lines 3827 3841 +14
==========================================
+ Hits 3271 3281 +10
- Misses 333 336 +3
- Partials 223 224 +1 ☔ View full report in Codecov by Sentry. |
aaee187 to
f961b64
Compare
f961b64 to
3aeba86
Compare
qweeah
reviewed
Jul 19, 2024
qweeah
reviewed
Jul 19, 2024
qweeah
requested changes
Jul 19, 2024
qweeah
reviewed
Jul 19, 2024
Contributor
|
BTW @TerryHowe Good job, this is an elegant refactoring! |
d7ed4d3 to
1bb892f
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7f9c005 to
769aeb2
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Isolate details about the progress channel from users